Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write default app config on app init #353

Merged
merged 6 commits into from
Jan 19, 2021

Conversation

sandeep-paliwal
Copy link
Contributor

@sandeep-paliwal sandeep-paliwal commented Dec 22, 2020

Always create .aio file with default app config for app init command.
Fixes #355

Description

When aio app is initialised with -y flag, .aio file was not created.
Fixed this by writing .aio file with default app config at app init. When import or CLI login is used, .aio file will be merged with project config.
Default app config includes, name of actions, dist and web-src folder. This will help users to customise app if required.

Related Issue

Motivation and Context

How Has This Been Tested?

unit tests, manual app init test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #353 (64b77c0) into master (3dab508) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         1331      1335    +4     
  Branches       219       219           
=========================================
+ Hits          1331      1335    +4     
Impacted Files Coverage Δ
src/commands/app/init.js 100.00% <100.00%> (ø)
src/lib/import.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dab508...64b77c0. Read the comment docs.

@shazron shazron changed the title Write default app config on app init fix: write default app config on app init Dec 23, 2020
src/lib/import.js Outdated Show resolved Hide resolved
src/lib/import.js Outdated Show resolved Hide resolved
src/lib/import.js Show resolved Hide resolved
@sandeep-paliwal sandeep-paliwal merged commit 36027b9 into master Jan 19, 2021
@shazron shazron deleted the write_default_app_config branch July 29, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio app init -y doesn't create the .aio file
2 participants