Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding skip-web-assets alias to skip-static #358

Merged
merged 2 commits into from
Jan 19, 2021
Merged

adding skip-web-assets alias to skip-static #358

merged 2 commits into from
Jan 19, 2021

Conversation

Himavanth
Copy link
Contributor

Description

Fixes #312

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #358 (36bd189) into master (4f19c74) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #358   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         1331      1331           
  Branches       219       219           
=========================================
  Hits          1331      1331           
Impacted Files Coverage Δ
src/commands/app/build.js 100.00% <100.00%> (ø)
src/commands/app/deploy.js 100.00% <100.00%> (ø)
src/commands/app/undeploy.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f19c74...36bd189. Read the comment docs.

@Himavanth Himavanth requested a review from moritzraho January 8, 2021 09:34
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@Himavanth Himavanth merged commit 3dab508 into master Jan 19, 2021
@Himavanth Himavanth deleted the web-assets branch January 19, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming mismatch static vs web-assets
2 participants