Additional ext reg changes - ext and ext point listing #421

sandeep-paliwal · 2021-06-29T10:28:40Z

Change impl prompt listing to dynamic, fetching extension point list from console
Add generic list command
Add list extension command to display implemented extensions and related details
and extension-points command to list xp available for the org
Added unit tests

Description

Related Issue

Motivation and Context

How Has This Been Tested?

manual tests

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

…from console Add generic list command Add list extension command to display implemented extensions and related details and extension-points command to list xp available for the org

moritzraho · 2021-06-29T12:53:07Z

src/lib/app-helper.js

+ * @param consoleCLI
+ */
+async function getAllExtensionPoints (consoleCLI) {
+  const projectConfig = aioConfig.get('project')


can you pass the aioConfig as param, it's available under the fullConfig.aio, that way we keep the loading of aioConfig inside the config-loader, that makes it easier for testing/mocking too

I have changed the function interface to accept orgId( don't need entire config anyway)

moritzraho · 2021-06-29T12:53:23Z

src/lib/app-helper.js

+ */
+async function getImplPromptChoices (consoleCLI) {
+  const defaultList = implPromptChoices
+  const projectConfig = aioConfig.get('project')


same comment here

moritzraho

Nice, good job integrating with new changes and generator-aio-console, especially because it's all ongoing work.

Just one double minor comment, otherwise lgtm !

Fix ext listing based on o/p changes from console API

Added ext point filtering to stop repeated from showing up

generic List command Extension-point List command Fixed linting

moritzraho

Comments below + missing tests for init, app-helper and add extension changes

src/lib/defaults.js

moritzraho · 2021-07-20T08:35:12Z

src/commands/app/add/extension.js

@@ -59,7 +58,8 @@ class AddExtensionCommand extends BaseCommand {

  async selectImplementations (flags, config) {
    const alreadyImplemented = config.implements
-    const availableChoices = implPromptChoices
+    const consoleCLI = await this.getLibConsoleCLI()
+    const availableChoices = await getImplPromptChoices(consoleCLI, config.aio)


I thought we decided that add extension and init should let the user choose extension points to implement from an hardcoded list, for two reasons:

there is no added benefit of adding an extension from a dynamic list for now because we anyway maintain the list in the CLI

dynamic list requires an extra request, slows down + more chance for bugs

cc @meryllblanchet @purplecabbage @sarahxxu

moritzraho · 2021-07-20T08:37:58Z

src/commands/app/init.js

@@ -108,7 +106,7 @@ class InitCommand extends BaseCommand {
    // 4. retrieve workspace details, defaults to Stage
    const workspace = await this.retrieveWorkspaceFromName(consoleCLI, org, project, flags.workspace)
    // 5. ask for exensionPoints, only allow selection for extensions that have services enabled in Org
-    const extensionPoints = await this.selectExtensionPoints(flags, orgSupportedServices)
+    const extensionPoints = await this.selectExtensionPoints(flags, orgSupportedServices, { login: true, orgId: org.id })


In case we keep dynamic extension list, please split this into two methods:
this.selectExtensionPointsStatic(flags, orgSupportedServices)
this.selectExtensionPointsDynamic(consoleCLI, flags, orgSupportedServices, orgId)

moritzraho · 2021-07-20T08:39:19Z

src/commands/app/init.js

-  async selectExtensionPoints (flags, orgSupportedServices = null) {
+  async selectExtensionPoints (flags, orgSupportedServices = null, options = {}) {
+    let consoleCLI
+    if (options.login) {


let's pass consoleCLI as input see comment above

moritzraho · 2021-07-20T08:40:37Z

src/commands/app/list/extension.js

+    const extConfig = this.getAppExtConfigs(flags)
+    const extSummary = {}
+
+    EXTENSION_POINT_LIST.forEach(extPoint => {


This is half dynamic half static.
I think in this case we can go full dynamic and get extension points too ?

…s and list extension points Updated unit tests

moritzraho · 2021-07-20T12:31:00Z

src/commands/app/list/extension.js

+        // get worker impl details
+        if (extension.operations.apply) {
+          // TODO extension.manifest.full.packages[extPoint.toString()] doesnt fetch package details
+          const pkgDetails = extension.manifest.full.packages['dx-asset-compute-worker-1']


that is not ok, the package name can be another.. why don't you simply print all operations, no need to filter on operation names ?

revert data mock change

moritzraho

lgtm

* support single app.config.yaml and extension manifest only endpoints * Support Multi-level config * added support for build * app deploy * support for run * support for run hooks * no-extension for blank * fix missing hooks * payload string * fix subscribe to services * support for default legacy app gen * fix console log * console logs * support for config change, application and $includes, needs changes in build/run/deploy * fixes and support for init --no-login * build, deploy, run with new config system * remove aio app use --workspace flag, rename --workspace-name to --workspace * support aio app init -w * install improvements * remove extensions flag, deploy to xt reg * keep workspace-name around * cleanup flags, introduce no- instead of skip- flags * undeploy * bundler fix * fix deploy/undeploy to xt registry * update exts names * welcome aio app add action * app delete * add/delete web assets * log web assets delete * add and delete events * wrap up app/delete commands * fix stage cdn url * expose gens via index.js * fix init --no-extensions * support for relative path to config * better action, web-src default path * fix run vscode config input * fix run local * support relative paths * absRoot == path.resolve * load as absolut path in runtime manifest * add op[view] metadata for dx/excshell/1 * fix undeploy --no-actions * fix undeploy + use fresh services for metadata * fix removed util * fix publish/unpublish * some logs + bin for aio-next * mocks on the way + fix backward compatibility for legacy apps * chalk.bold new exte point log * dx experience cloud rename template name * fixture apps and mocks v1 * mocks done + one is tested * mock include indexes, add tests for config, fix some mocks * config loader 1 test case per mock app * tests for app info + show how to use mocks * add preid to .npmrc * add unit-tests npm script * removed posttest npm script (added lint script to test npm script) * Mock rewrite utility improvements, more config loader tests (#422) * improved mock rewrite config utility, more tests for config loader * attempt to fix windows tests * config-loader 100% * fixture module names * path.resolve can you save me ? * feat: add `aio app test` for extension registry changes * worker opcode change + tests BaseCommand & Init (#424) * More tests: BaseCommand & Init * worker => apply * init 100 coverage * fix win tests * coverage * App helper tests + fix config loader once (#427) * App helpers test + fix config-loader tests * 100% cov on app helper * add tests for app: run, build, deploy, and undeploy (Extension Registry release) (#426) * delete ci - test coverage 100% * delete event - test coverage 100% * delete web-assets - test coverage 100%, fixed logic bugs for noFrontend, and user declines * `aio app list` additions - ext and ext point listing (#421) * Change impl prompt listing to dynamic, fetching extension point list from console * Add generic list command * Add list extension command to display implemented extensions and related details and extension-points command to list xp available for the org * Add review comments, Fix ext listing based on o/p changes from console API * Fix extension list processing * improve o/p for extension point listing * Fix issue with aio app init, Added ext point filtering to stop repeated from showing up * Fix fetching org id in case of import * Handle --no-login case for aio app init * Fixed extension list command with new asset-compute xp operation (apply) * Added unit tests for -- generic List command -- Extension-point List command -- Fixed linting * Added unit tests for list extension command * Change o/p of extension list to show only impl and not src from package * fix get-url and logs (#432) * fixed unit tests and coverage for lib files (Ext Reg support) (#431) * Unit tests with 100% codecov for all app add cmds (#429) * remove deprecation notice for manifest (#434) * Fixes: app logs, deploy no-login legacy+app, no-build, no extra update extpoint call (#437) * fixes: app logs * fixes: deploy no-login legacy+app, no-build, no extra remove call * Delete test coverage (#438) * delete:extension tests and coverage, fix: returns error if prompt returns false * delete action - test coverage * fix: path.dirname mock - replace with spyOn * fix: app/use unit tests * fix: app/get-url unit tests * app/get-url - remove unused dep * fix: app/logs unit tests (and implementation) * fix: linter issues * fix: attempt to fix phantom CI failure (1 unit test failure left) * rename nui operation apply => workerProcess (#439) * fix: ci unit test issue for app/delete/event * fix: failing unit tests on Windows (#441) * fix: app/delete/action Windows unit tests * fix: app/add/web-assets Windows unit tests * fix: lib/vscode Windows unit tests Co-authored-by: Jesse MacFadyen <purplecabbage@gmail.com> Co-authored-by: Shazron Abdullah <shaz@adobe.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: sandeep-paliwal <spaliwal@adobe.com> Co-authored-by: Himavanth <contacthima@yahoo.com>

Change impl prompt listing to dynamic, fetching extension point list …

556778a

…from console Add generic list command Add list extension command to display implemented extensions and related details and extension-points command to list xp available for the org

moritzraho reviewed Jun 29, 2021

View reviewed changes

sandeep-paliwal added 10 commits June 30, 2021 10:00

Add review comments

2407d53

Fix ext listing based on o/p changes from console API

Fix extension list processing

cfe7ae3

improve o/p for extension point listing

1bed661

Fix issue with aio app init

16637b8

Added ext point filtering to stop repeated from showing up

Fix fetching org id in case of import

1872074

Handle --no-login case for aio app init

55fabe8

Merge branch 'release-ext-reg' into additional-ext-changes

5d2a4eb

Fixed extension list command with new asset-compute xp operation (apply)

8a2c32a

Added unit tests for

6e22cdc

generic List command Extension-point List command Fixed linting

Added unit tests for list extension command

60c0184

moritzraho requested changes Jul 20, 2021

View reviewed changes

sandeep-paliwal added 2 commits July 20, 2021 17:43

Reverted to Hardcoded extension listing for app init , list extension…

cf83b3c

…s and list extension points Updated unit tests

revert delete command changes

6c2a52d

moritzraho reviewed Jul 20, 2021

View reviewed changes

Change o/p of extension list to show only impl and not src from package

5098371

revert data mock change

moritzraho approved these changes Jul 20, 2021

View reviewed changes

shazron merged commit 8aa4d49 into release-ext-reg Jul 21, 2021

shazron deleted the additional-ext-changes branch July 21, 2021 16:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Additional ext reg changes - ext and ext point listing #421

Additional ext reg changes - ext and ext point listing #421

sandeep-paliwal commented Jun 29, 2021 •

edited

Loading

moritzraho Jun 29, 2021

sandeep-paliwal Jul 20, 2021

moritzraho Jun 29, 2021

moritzraho left a comment

moritzraho left a comment

moritzraho Jul 20, 2021

moritzraho Jul 20, 2021

moritzraho Jul 20, 2021

moritzraho Jul 20, 2021

moritzraho Jul 20, 2021

moritzraho Jul 20, 2021

moritzraho left a comment

Additional ext reg changes - ext and ext point listing #421

Additional ext reg changes - ext and ext point listing #421

Conversation

sandeep-paliwal commented Jun 29, 2021 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moritzraho left a comment

Choose a reason for hiding this comment

moritzraho left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moritzraho left a comment

Choose a reason for hiding this comment

sandeep-paliwal commented Jun 29, 2021 •

edited

Loading