inform user if no actions were built

src/commands/app/build.js

@@ -19,7 +19,7 @@ const { runScript, writeConfig } = require('../../lib/app-helper')
 const RuntimeLib = require('@adobe/aio-lib-runtime')
 const { bundle } = require('@adobe/aio-lib-web')
 const fs = require('fs-extra')
-// const aioLogger = require('@adobe/aio-lib-core-logging')('@adobe/aio-cli-plugin-app:build', { provider: 'debug' })
+const aioLogger = require('@adobe/aio-lib-core-logging')('@adobe/aio-cli-plugin-app:build', { provider: 'debug' })
 
 class Build extends BaseCommand {
   async run () {
@@ -72,13 +72,24 @@ class Build extends BaseCommand {
 
     if (flags.actions) {
       if (config.app.hasBackend && (flags['force-build'] || !fs.existsSync(config.actions.dist))) {
-        spinner.start(`Building actions for '${name}'`)
         try {
+          let builtList = []
           const script = await runScript(config.hooks['build-actions'])
+          aioLogger.debug(`run hook for 'build-actions' for actions in '${name}' returned ${script}`)
+          spinner.start(`Building actions for '${name}'`)
           if (!script) {
-            await RuntimeLib.buildActions(config, filterActions)
+            builtList = await RuntimeLib.buildActions(config, filterActions)
           }
-          spinner.succeed(chalk.green(`Building actions for '${name}'`))
+          if (builtList.length > 0) {
+            spinner.succeed(chalk.green(`Built ${builtList.length} action(s) for '${name}'`))
+          } else {
+            if (script) {
+              spinner.fail(chalk.green(`build-action skipped by hook '${name}'`))
+            } else {
+              spinner.fail(chalk.green(`No actions built for '${name}'`))
+            }
+          }
+          aioLogger.debug(`RuntimeLib.buildActions returned ${builtList}`)
         } catch (err) {
           spinner.fail(chalk.green(`Building actions for '${name}'`))
           throw err

test/__mocks__/ora.js

@@ -10,26 +10,29 @@ OF ANY KIND, either express or implied. See the License for the specific languag
 governing permissions and limitations under the License.
 */
 
+const spinner = {
+  stopAndPersist: jest.fn(() => {
+    // console.error('stopAndPersist')
+  }),
+  stop: jest.fn((value) => {
+    console.error(value)
+  }),
+  start: jest.fn((value) => {
+    console.error(value)
+  }),
+  warn: jest.fn((value) => {
+    console.error(value)
+  }),
+  info: jest.fn((msg) => {
+    console.log(msg)
+  }),
+  error: jest.fn(),
+  fail: jest.fn(),
+  succeed: jest.fn((value) => {
+    console.error(value)
+  })
+}
+
 module.exports = () => {
-  const spinner = {
-    stopAndPersist: jest.fn(() => {
-      // console.error('stopAndPersist')
-    }),
-    stop: jest.fn(),
-    start: jest.fn(() => {
-      // console.error('start')
-    }),
-    warn: jest.fn(() => {
-      // console.error('warn')
-    }),
-    info: jest.fn((msg) => {
-      console.log(msg)
-    }),
-    error: jest.fn(),
-    fail: jest.fn(),
-    succeed: jest.fn(() => {
-      // console.error('succeed')
-    })
-  }
   return spinner
 }

test/commands/app/build.test.js

@@ -16,6 +16,9 @@ const path = require('path')
 const cloneDeep = require('lodash.clonedeep')
 const dataMocks = require('../../data-mocks/config-loader')
 
+const ora = require('ora')
+jest.mock('ora')
+
 const mockFS = require('fs-extra')
 jest.mock('fs-extra')
 
@@ -199,16 +202,20 @@ test('flags', async () => {
   expect(TheCommand.flags.extension.exclusive).toEqual(['action'])
 })
 
+let spinner
+
 describe('run', () => {
   let command
   beforeEach(() => {
+    spinner = ora()
     command = new TheCommand([])
     command.error = jest.fn()
     command.log = jest.fn()
     command.getAppExtConfigs = jest.fn()
     command.appConfig = cloneDeep(sampleAppConfig)
 
     mockRuntimeLib.buildActions.mockReset()
+    mockRuntimeLib.buildActions.mockReturnValue([])
   })
 
   afterEach(() => {
@@ -301,7 +308,6 @@ describe('run', () => {
 
   test('build & deploy --skip-static', async () => {
     command.getAppExtConfigs.mockReturnValueOnce(createAppConfig(command.appConfig))
-
     command.argv = ['--skip-static']
     await command.run()
     expect(command.error).toHaveBeenCalledTimes(0)
@@ -311,7 +317,6 @@ describe('run', () => {
 
   test('build & deploy --skip-web-assets', async () => {
     command.getAppExtConfigs.mockReturnValueOnce(createAppConfig(command.appConfig))
-
     command.argv = ['--skip-web-assets']
     await command.run()
     expect(command.error).toHaveBeenCalledTimes(0)
@@ -322,9 +327,11 @@ describe('run', () => {
   test('build & deploy only some actions using --action', async () => {
     const appConfig = createAppConfig(command.appConfig)
     command.getAppExtConfigs.mockReturnValueOnce(appConfig)
-
-    command.argv = ['--skip-static', '-a', 'a', '-a', 'b', '--action', 'c']
+    command.argv = ['--skip-static', '-a', 'a', '-a=b', '--action', 'c']
+    mockRuntimeLib.buildActions.mockReturnValue(['a', 'b', 'c'])
     await command.run()
+    expect(spinner.start).toBeCalledWith('Building actions for \'application\'')
+    expect(spinner.succeed).toBeCalledWith(expect.stringContaining('Built 3 action(s) for \'application\''))
     expect(command.error).toHaveBeenCalledTimes(0)
     expect(mockRuntimeLib.buildActions).toHaveBeenCalledTimes(1)
     expect(mockRuntimeLib.buildActions).toHaveBeenCalledWith(appConfig.application, ['a', 'b', 'c'])