Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI/CD deploy error #450

Merged
merged 5 commits into from
Aug 5, 2021
Merged

Fix CI/CD deploy error #450

merged 5 commits into from
Aug 5, 2021

Conversation

sandeep-paliwal
Copy link
Contributor

Helps in fixing adobe/aio-apps-action#10
For CI/CD deploy, the generated JWT token doesn't have scopes to get services details for a workspace.
These details can be set as env var to avoid the API call, but while reading we need to convert them to JSON objects for further processing.
Following changes help support this.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

unit tests and manual test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

These details can also be set as env var and need to be converted to json object from string for such cases.
Added unit tests
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #450 (305b93f) into master (6214800) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #450   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         2462      2466    +4     
  Branches       423       426    +3     
=========================================
+ Hits          2462      2466    +4     
Impacted Files Coverage Δ
src/lib/app-helper.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6214800...305b93f. Read the comment docs.

@purplecabbage purplecabbage merged commit d1d645c into master Aug 5, 2021
@purplecabbage purplecabbage deleted the deploy_cicd_fix branch August 5, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants