Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #443 - ACNA-1239 #456

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Fix #443 - ACNA-1239 #456

merged 2 commits into from
Aug 5, 2021

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Aug 3, 2021

Description

aio app deploy -a on an action that does not exist, shows a successful deploy

Related Issue

#443

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #456 (1ea512c) into master (de8f8e3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #456   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         2458      2462    +4     
  Branches       421       423    +2     
=========================================
+ Hits          2458      2462    +4     
Impacted Files Coverage Δ
src/commands/app/deploy.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8f8e3...1ea512c. Read the comment docs.

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@purplecabbage purplecabbage merged commit 46238bb into adobe:master Aug 5, 2021
@purplecabbage purplecabbage deleted the ACNA1239 branch August 5, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants