Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app run & deploy messages should differentiate between web action and non-web action URLs #457

Merged
merged 6 commits into from
Aug 5, 2021

Conversation

shazron
Copy link
Member

@shazron shazron commented Aug 4, 2021

Fixes #436

How Has This Been Tested?

npm test

Screenshots (if appropriate):

aio app deploy
Screen Shot 2021-08-04 at 9 55 04 PM

aio app run
Screen Shot 2021-08-04 at 9 55 19 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #457 (1004dff) into master (d1d645c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #457   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         2466      2489   +23     
  Branches       426       434    +8     
=========================================
+ Hits          2466      2489   +23     
Impacted Files Coverage Δ
src/commands/app/deploy.js 100.00% <100.00%> (ø)
src/lib/app-helper.js 100.00% <100.00%> (ø)
src/lib/deploy-actions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d645c...1004dff. Read the comment docs.

@shazron shazron marked this pull request as ready for review August 4, 2021 15:51
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@purplecabbage purplecabbage merged commit aed6ddb into master Aug 5, 2021
@purplecabbage purplecabbage deleted the ACNA-1232 branch August 5, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App run & deploy messages should differentiate between web action and non-web action URLs
3 participants