Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ctrl-c was not working properly for aio app run on windows #458

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

Himavanth
Copy link
Contributor

@Himavanth Himavanth commented Aug 5, 2021

Description

Fixes #455

Related Issue

Motivation and Context

How Has This Been Tested?

aio app run on Windows VM

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #458 (99c5a8b) into master (46238bb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #458   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         2462      2462           
  Branches       423       423           
=========================================
  Hits          2462      2462           
Impacted Files Coverage Δ
src/lib/cleanup.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46238bb...99c5a8b. Read the comment docs.

@Himavanth Himavanth changed the title fix: ctrl-c was not working properly for aio app run fix: DO NOT MERGE.. Still testing.. ctrl-c was not working properly for aio app run Aug 5, 2021
@Himavanth Himavanth changed the title fix: DO NOT MERGE.. Still testing.. ctrl-c was not working properly for aio app run fix: ctrl-c was not working properly for aio app run Aug 5, 2021
@Himavanth Himavanth changed the title fix: ctrl-c was not working properly for aio app run fix: ctrl-c was not working properly for aio app run on windows Aug 5, 2021
@purplecabbage
Copy link
Member

lgtm!

@purplecabbage purplecabbage merged commit 6214800 into master Aug 5, 2021
@purplecabbage purplecabbage deleted the ctrl-c-fix branch August 5, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio app run termination issue on Windows 10
3 participants