Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterize extensions #476

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Sep 15, 2021

Description

We have some dialog input that is not easily automated for e2e/integration tests. This pr adds a --extension:String flag to allow easy testing.

currently --extension is expected to be one ( or more ) of [dx/asset-compute/worker/1, dx/excshell/1, application]

Related Issue

https://jira.corp.adobe.com/browse/ACNA-1271

How Has This Been Tested?

with tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment otherwise lgtm

src/commands/app/init.js Outdated Show resolved Hide resolved
Copy link
Contributor

@sandeep-paliwal sandeep-paliwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #476 (f1d0670) into master (d15b5a9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #476   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         2252      2258    +6     
  Branches       373       375    +2     
=========================================
+ Hits          2252      2258    +6     
Impacted Files Coverage Δ
src/commands/app/init.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15b5a9...f1d0670. Read the comment docs.

@purplecabbage purplecabbage merged commit 0c90263 into adobe:master Sep 16, 2021
@purplecabbage purplecabbage deleted the skip-prompts branch September 16, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants