[ACNA-1304] Filter actions deployments. #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On file change it should only deploy it's respective action. It should not redeploy twice the same action packages if redeployment is called unless files were changed.
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 2262 2278 +16
Branches 375 377 +2
=========================================
+ Hits 2262 2278 +16
Continue to review full report at Codecov.
|
added a new way of filtering. filtering by the already built actions.
moritzraho
reviewed
Sep 23, 2021
…r filePath updated unit tests.
…nputs for the same action file.
moritzraho
requested changes
Oct 6, 2021
moritzraho
reviewed
Oct 11, 2021
.gitignore
Outdated
| @@ -14,3 +14,11 @@ oclif.manifest.json | |||
| package-lock.json | |||
|
|
|||
| bin/openwhisk-standalone*.jar | |||
| /.idea/.gitignore | |||
moritzraho
reviewed
Oct 11, 2021
src/lib/actions-watcher.js
Outdated
| Object.entries(config.manifest.full.packages).forEach(([, pkg]) => { | ||
| if (pkg.actions) { | ||
| Object.entries(pkg.actions).forEach(([actionName, action]) => { | ||
| if (action.function.includes(filePath)) { |
There was a problem hiding this comment.
Let's be double safe here, this might not work if filePath or action.funtion is a windows path, or if filePath is absolut. What about making both to unix and absolut and check for equality ?
There was a problem hiding this comment.
Yep, you are right, action.function will have a Unix path even if it's generated on windows.
moritzraho
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the way deployments go.
On file change, it should deploy only its respective action.
It should not redeploy twice the same action packages if redeployment is called unless files were changed.
Extends: adobe/aio-lib-runtime#75
Description
Create a filter array based on the current file changed. This will help the deploy function to decide which actions to deploy.
Related Issue
#468
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: