Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACNA-1249][ACNA-1251] Bootstrap extensions XOR extensionless & Add GH actions by default on init #486

Merged
merged 11 commits into from
Oct 13, 2021
Merged

[ACNA-1249][ACNA-1251] Bootstrap extensions XOR extensionless & Add GH actions by default on init #486

merged 11 commits into from
Oct 13, 2021

Conversation

florind-ens
Copy link
Contributor

@florind-ens florind-ens commented Sep 29, 2021 •
edited by shazron
Loading

Description

User is provided with an way to initiate a blank application app via aio app init
GH actions are added by default on the init step.

Enabled the Standalone Application option on the Choose Extensions step.

Related Issue

Fixes #453

Motivation and Context

How Has This Been Tested?

Manually
demo

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@florind-ens florind-ens self-assigned this Sep 29, 2021
@florind-ens florind-ens changed the title [ACNA-1249] Let developers bootstrap extensions XOR extensionless app from the selection menu [ACNA-1249][ACNA-1251] Bootstrap extensions XOR extensionless & Add GH actions by default on init Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021 •
edited
Loading

Codecov Report

Merging #486 (b9c925b) into master (6fcbc23) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #486   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         2267      2269    +2     
  Branches       372       372           
=========================================
+ Hits          2267      2269    +2
Impacted Files Coverage Δ
src/commands/app/init.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fcbc23...b9c925b. Read the comment docs.

moritzraho
moritzraho approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment

src/commands/app/init.js Outdated Show resolved Hide resolved
@shazron shazron merged commit 2f6e94e into master Oct 13, 2021
@shazron shazron deleted the story/ACNA-1249-boostrap-extensionless-apps branch October 13, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzraho moritzraho moritzraho approved these changes

@shazron shazron shazron approved these changes

@purplecabbage purplecabbage Awaiting requested review from purplecabbage

Assignees

@florind-ens florind-ens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let developers bootstrap extensions XOR extensionless app from the selection menu
3 participants
@florind-ens @shazron @moritzraho