App Builder experience for Configurable Logging

[buskamuza]

Added commands for managing log forwarding configuration.

• added app:config:get:log-forwarding command
• added app:config:set:log-forwarding command
• added app:config:get:log-forwarding:errors command
• updated log forwarding config on server during app:deploy command
• updated app:logs command to display info message in case custom log forwarding is configured
• save log forwarding settings to project config

Description

See #501 and https://jira.corp.adobe.com/browse/DEVX-1244 (internal)

Related Issue

• Add commands for managing log forwarding #501
• Generic API for Log Forwarding Configuration aio-lib-runtime#83
• Generic implementation of interactive log-forwarding:set command aio-cli-plugin-runtime#254
• Log Forwarding Set API Returns JSON instead of Text aio-lib-runtime#93

Motivation and Context

See #501

How Has This Been Tested?

Automated and manual testing.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #502 (bad8b16) into master (0a4f10e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #502    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           43        50     +7     
  Lines         2324      2556   +232     
  Branches       422       453    +31     
==========================================
+ Hits          2324      2556   +232     

Impacted Files	Coverage Δ
src/commands/app/config/get/index.js	100.00% <100.00%> (ø)
src/commands/app/config/get/log-forwarding.js	100.00% <100.00%> (ø)
...c/commands/app/config/get/log-forwarding/errors.js	100.00% <100.00%> (ø)
src/commands/app/config/index.js	100.00% <100.00%> (ø)
src/commands/app/config/set/index.js	100.00% <100.00%> (ø)
src/commands/app/config/set/log-forwarding.js	100.00% <100.00%> (ø)
src/commands/app/deploy.js	100.00% <100.00%> (ø)
src/commands/app/logs.js	100.00% <100.00%> (ø)
src/lib/log-forwarding.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4f10e...bad8b16. Read the comment docs.

[purplecabbage]

mostly nitpicky stuff, but this seems to be a lot more code than required ... more code, more bugs

Deploy can be called with --[no-]actions in which case we should not be doing anything with log-forwarding.

[buskamuza]

mostly nitpicky stuff, but this seems to be a lot more code than required ... more code, more bugs

Deploy can be called with --[no-]actions in which case we should not be doing anything with log-forwarding.

Updated

[purplecabbage]

a couple issues I have found.

• when setting with https:// the server does not return an https:// url so aio app config get log-forwarding always shows a mismatch
• changing type via aio app config set log-forwarding overwrites values in .aio but leaves keys in .env

[buskamuza]

changing type via aio app config set log-forwarding overwrites values in .aio but leaves keys in .env

This was discussed with Manik. It leaves keys in .env if you change destination type. If you use the same destination type the key is overwritten. So far we agreed that this is expected behavior.

[buskamuza]

when setting with https:// the server does not return an https:// url so aio app config get log-forwarding always shows a mismatch

Fixed. Updated Runtime API to return sanitized settings and aio CLI then stores this instead of what the user provided. Secrets are not exchanged and stored as provided by the user. See also new PR adobe/aio-lib-runtime#93 necessary to cover this.