Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for daily.yml npm install and test #503

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Fix for daily.yml npm install and test #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,23 +44,24 @@
},
"devDependencies": {
"@adobe/aio-lib-test-proxy": "^1.0.0",
"@adobe/eslint-config-aio-lib-config": "^1.3.0",
"@adobe/eslint-config-aio-lib-config": "^1.4.0",
"@oclif/dev-cli": "^1.21.3",
"@types/jest": "^26.0.10",
"babel-runtime": "^6.26.0",
"codecov": "^3.6.1",
"eol": "^0.9.1",
"eslint": "^6.0.0",
"eslint-config-standard": "^14.1.1",
"eslint-plugin-import": "^2.20.2",
"eslint-plugin-jest": "^23.13.0",
"eslint-plugin-jsdoc": "^25.0.0",
"eslint-plugin-node": "^10.0.0",
"eslint-plugin-promise": "^4.2.1",
"eslint": "^7.32.0",
"eslint-config-standard": "^16.0.3",
"eslint-plugin-import": "^2.25.3",
"eslint-plugin-jest": "^23.20.0",
"eslint-plugin-jsdoc": "^37.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^5.2.0",
"eslint-plugin-standard": "^4.0.1",
"jest": "^26.6.3",
"jest-plugin-fs": "^2.9.0",
"stdout-stderr": "^0.1.9"
"stdout-stderr": "^0.1.9",
"typescript": "^4.5.2"
},
"engineStrict": true,
"engines": {
Expand Down
14 changes: 8 additions & 6 deletions src/commands/app/deploy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,14 @@ class Deploy extends BuildCommand {
}

async deploySingleConfig (name, config, flags, spinner) {
const onProgress = !flags.verbose ? info => {
spinner.text = info
} : info => {
spinner.info(chalk.dim(`${info}`))
spinner.start()
}
const onProgress = !flags.verbose
? info => {
spinner.text = info
}
: info => {
spinner.info(chalk.dim(`${info}`))
spinner.start()
}

// build phase
if (flags.build) {
Expand Down
14 changes: 8 additions & 6 deletions src/commands/app/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,14 @@ class Run extends BaseCommand {
}
}

const onProgress = !flags.verbose ? info => {
spinner.text = info
} : info => {
spinner.info(chalk.dim(`${info}`))
spinner.start()
}
const onProgress = !flags.verbose
? info => {
spinner.text = info
}
: info => {
spinner.info(chalk.dim(`${info}`))
spinner.start()
}

const frontendUrl = await runDev(config, this.config.dataDir, runOptions, onProgress)
try {
Expand Down
14 changes: 8 additions & 6 deletions src/commands/app/undeploy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,14 @@ class Undeploy extends BaseCommand {
}

async undeployOneExt (extName, config, flags, spinner) {
const onProgress = !flags.verbose ? info => {
spinner.text = info
} : info => {
spinner.info(chalk.dim(`${info}`))
spinner.start()
}
const onProgress = !flags.verbose
? info => {
spinner.text = info
}
: info => {
spinner.info(chalk.dim(`${info}`))
spinner.start()
}
// undeploy
try {
await runScript(config.hooks['pre-app-undeploy'])
Expand Down
2 changes: 1 addition & 1 deletion src/lib/deploy-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const { deployActions } = require('@adobe/aio-lib-runtime')
* Deploys actions.
*
* @param {object} config see src/lib/config-loader.js
* @param {boolean} isLocal=false set to true if it's a local deploy
* @param {boolean} isLocal default false, set to true if it's a local deploy
* @param {Function} [log] a log function
* @param {boolean} filter true if a filter by built actions is desired.
*/
Expand Down