Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ACNA-1475 - verbose logging for headless application or local runtime #506

Merged
merged 13 commits into from
Mar 15, 2022

Conversation

florind-ens
Copy link
Contributor

Headless apps are verbose by default.
aio app get-url --local will print out local action URLs.
aio app run --local will enable verbose logging.

Description

Related Issue

#482
#435

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

headless app verbose by default
verbose for headless app or apps running locally
…ess-action-url

# Conflicts:
#	src/commands/app/run.js
#	src/lib/deploy-actions.js
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #506 (5b3dd8f) into master (ed46cbe) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #506   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2584      2595   +11     
  Branches       464       469    +5     
=========================================
+ Hits          2584      2595   +11     
Impacted Files Coverage Δ
src/commands/app/get-url.js 100.00% <100.00%> (ø)
src/commands/app/run.js 100.00% <100.00%> (ø)
src/lib/deploy-actions.js 100.00% <100.00%> (ø)
src/lib/run-dev.js 100.00% <100.00%> (ø)
src/lib/run-local-runtime.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed46cbe...5b3dd8f. Read the comment docs.

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor change in the doc

src/commands/app/get-url.js Outdated Show resolved Hide resolved
@shazron shazron changed the title feat. ACNA-1475 Verbose Logging for headless application || local runtime feat: ACNA-1475 - verbose logging for headless application or local runtime Mar 7, 2022
@florind-ens florind-ens merged commit a989b5a into master Mar 15, 2022
@shazron shazron deleted the bug/ACNA-1475-headless-action-url branch March 15, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants