Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: oclif v2 migration #517

Merged
merged 11 commits into from
Jun 21, 2022
Merged

chore: oclif v2 migration #517

merged 11 commits into from
Jun 21, 2022

Conversation

florind-ens
Copy link
Contributor

@florind-ens florind-ens commented Feb 22, 2022

Description

Some testing is needed before I switch it to Ready for Review.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@florind-ens florind-ens changed the title smoke test needed. Ocliv v2 migration Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #517 (dc2f300) into master (073bb5b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #517   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2600      2598    -2     
  Branches       473       473           
=========================================
- Hits          2600      2598    -2     
Impacted Files Coverage Δ
src/commands/app/add/action.js 100.00% <100.00%> (ø)
src/commands/app/add/ci.js 100.00% <100.00%> (ø)
src/commands/app/add/event.js 100.00% <100.00%> (ø)
src/commands/app/add/extension.js 100.00% <100.00%> (ø)
src/commands/app/add/index.js 100.00% <100.00%> (ø)
src/commands/app/add/service.js 100.00% <100.00%> (ø)
src/commands/app/add/web-assets.js 100.00% <100.00%> (ø)
src/commands/app/build.js 100.00% <100.00%> (ø)
src/commands/app/config/get/index.js 100.00% <100.00%> (ø)
src/commands/app/config/index.js 100.00% <100.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073bb5b...dc2f300. Read the comment docs.

@florind-ens florind-ens marked this pull request as ready for review February 28, 2022 12:21
@shazron shazron changed the title Ocliv v2 migration Oclif v2 migration Mar 7, 2022
@shazron shazron changed the title Oclif v2 migration chore: oclif v2 migration Mar 7, 2022
@purplecabbage purplecabbage merged commit a10b14c into master Jun 21, 2022
@purplecabbage purplecabbage deleted the story/oclif-v2 branch June 21, 2022 23:20
@purplecabbage purplecabbage restored the story/oclif-v2 branch June 22, 2022 00:21
@purplecabbage purplecabbage deleted the story/oclif-v2 branch June 22, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants