Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1533 - update integration_type in config.json schema #520

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Mar 7, 2022

Description

The Developer Console added three more types, and our config.json schema did not have the new values and was failing import. The three new integration types were added into the schema, and tests updated.

Related Issue

Closes #519

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron requested a review from purplecabbage March 7, 2022 15:17
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #520 (eac54bd) into master (511a1b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2571      2571           
  Branches       460       460           
=========================================
  Hits          2571      2571           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 511a1b9...eac54bd. Read the comment docs.

@purplecabbage
Copy link
Member

Lgtm!
Nit: I'd prefer to see the enum span multi lines to easier track commit changes.

@shazron
Copy link
Member Author

shazron commented Mar 7, 2022

Lgtm! Nit: I'd prefer to see the enum span multi lines to easier track commit changes.

updated

@shazron shazron merged commit 9b3be9c into master Mar 7, 2022
@shazron shazron deleted the integration-type-update branch March 7, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update integration_type in config.json schema
2 participants