Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added a friendly message asking for terms acceptance. #524

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

florind-ens
Copy link
Contributor

Description

The prompt for developers' terms should also include a nice message asking them to accept the terms.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #524 (3f04b51) into master (ba4b60f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #524   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2600      2600           
  Branches       472       472           
=========================================
  Hits          2600      2600           
Impacted Files Coverage Δ
src/commands/app/init.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba4b60f...3f04b51. Read the comment docs.

@shazron shazron changed the title fix. Added a friendly message asking for terms acceptance. fix: added a friendly message asking for terms acceptance. Mar 31, 2022
@florind-ens florind-ens merged commit 983a617 into master Mar 31, 2022
@shazron shazron deleted the fix/terms-acceptance branch August 25, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants