Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update @parcel/reporter-cli to 2.5.0 #531

Merged
merged 2 commits into from
May 13, 2022
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Apr 25, 2022

Motivation and Context

The existing version is a pre-release, update to the released version.
There might be caveats; see adobe/aio-lib-web#158

Closes #533

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron requested review from Himavanth and purplecabbage and removed request for Himavanth April 25, 2022 01:27
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #531 (b18805c) into master (5ef5b2d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #531   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2600      2600           
  Branches       472       472           
=========================================
  Hits          2600      2600           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef5b2d...b18805c. Read the comment docs.

@shazron
Copy link
Member Author

shazron commented Apr 26, 2022

See adobe/aio-lib-web#158 (comment)

Unclear if it has the same effect (the breaking changes), since it's a reporter plugin. In any case the code comment here suggests that it should be re-factored into aio-lib-web:

// TODO: Move this and bundleServe to aio-lib-web so we can remove the parcel dependency
bundleOptions.additionalReporters = [
{ packageName: '@parcel/reporter-cli', resolveFrom: __filename }
]

Copy link
Member

@purplecabbage purplecabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For next major right?

@shazron
Copy link
Member Author

shazron commented May 13, 2022

For next major right?

no, as I commented above, it's just a reporter plugin when we do aio app run (for local serve), and it's an upgrade from 2.0-beta to 2.5.0 so it wasn't a major bump anyway.

@shazron shazron merged commit 611ba4d into master May 13, 2022
@shazron shazron deleted the update-deps-1 branch May 13, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update parcel/reporter-cli
2 participants