Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force build on every aio app run (for switching from remote and local contexts) #551

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Jun 6, 2022

Description

Fixes #542
(see issue for use case)

In a nutshell, we will always force deploy actions on every aio app run (doesn't matter if there are no code changes).

How Has This Been Tested?

npm test
manual test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #551 (17266b8) into master (6c7ca51) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #551   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2600      2600           
  Branches       472       473    +1     
=========================================
  Hits          2600      2600           
Impacted Files Coverage Δ
src/lib/build-actions.js 100.00% <100.00%> (ø)
src/lib/run-dev.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7ca51...17266b8. Read the comment docs.

@shazron shazron marked this pull request as draft June 9, 2022 15:27
@shazron
Copy link
Member Author

shazron commented Jun 9, 2022

need to test for a new use case:

  1. aio app run --local
  2. use curl to connect to the local action, get success/error.
  3. run aio app run --local again
  4. use curl to connect to the local action again, Expected: success/error (not resource not found/404)

Action code is never saved on the local server, you will always have to redeploy code.

@shazron
Copy link
Member Author

shazron commented Jun 9, 2022

new use case: passes (I was in a wrong branch before)

@shazron shazron marked this pull request as ready for review June 9, 2022 16:16
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@purplecabbage
Copy link
Member

this seems like it should have been handled by the pr that added build caching
I doubt it would have been written any differently though ...
looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants