fix: ACNA-1687 | fix option skipInstall for generators #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2598 2607 +9
Branches 473 473
=========================================
+ Hits 2598 2607 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
10 tasks
arjuncooliitr
requested review from
moritzraho,
shazron,
sandeep-paliwal,
purplecabbage,
amulyakashyap09 and
MichaelGoberling
10 tasks
arjuncooliitr
changed the title
arjuncooliitr
changed the title
shazron
added a commit
to adobe/aio-cli-plugin-app-templates
that referenced
this pull request
Jul 28, 2022
…n (install command) (#19) * fix: when the template is run, the options were not being passed to the generator The previous usage of env.run, the options are actually the run options, and not the generator options. This has the proper usage. Reference: https://yeoman.github.io/environment/Environment.html#run * fix: ACNA-1732 - yeoman run skip-install work-around See adobe/aio-cli-plugin-app#561 * fixed README.md with oclif readme markers, then re-gen docs docs are generated with `npm run prepack` (which is run before the package is published usually)
moritzraho
approved these changes
Jul 29, 2022
|
This looks good. We can use git blame or other means to go back in time ... no need to maintain historical code in the comments. |
purplecabbage
approved these changes
Aug 11, 2022
|
Hi @purplecabbage, Thanks for reviewing. I have removed the historic code comment. Can I merge this PR now? |
sandeep-paliwal
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed option
skipInstallfor yeoman generators used for scaffolding App Builder AppsDescription
This PR aims to fix skipInstall options issue with yeoman generators. There is a slight change to how to use this option to make it work.
Related Issue
#554
Motivation and Context
npm dependencies seem to be installed twice once after the base-app gets generated and at the end before the app initialization is over
Expected behaviour: npm dependencies should only be installed at the end of the project initialization once the package.json deps are all defined.
How Has This Been Tested?
Locally tested by creating an app - npm packages are now installed only at the end. Generators skip installing packages. All units tests run successful locally.
Screenshots (if appropriate):
Generators skipping installing packages:
Types of changes
Checklist: