Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1741 - invalid config error #565

Merged
merged 7 commits into from
Aug 23, 2022

Conversation

amulyakashyap09
Copy link
Contributor

@amulyakashyap09 amulyakashyap09 commented Aug 19, 2022

Description

  • aio-cli throws error of invalid credentials when validated against config schema
  • When api mesh service is added, it has a type of authorisation mechanism which only needs apikey (client id) NO client_secret key is required
  • At backend it throws error as it requires client_secret too

Related Issue

ACNA-1741

Motivation and Context

This is one of critical issues as it does not generate a app builder project

How Has This Been Tested?

  • Test case fixtures has been added for valid.config.json and 100% passing
  • Test case fixtures has been added for invalid.config.json and 100% passing
  • Tested with Local repo linking between aio-cli-plugin-app and aio-cli
  • App builder project is generating without any error.

Screenshots (if appropriate):

Screenshot 2022-08-19 at 1 10 55 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #565 (eee9583) into master (ba5d8cb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #565   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2607      2607           
  Branches       473       473           
=========================================
  Hits          2607      2607           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sandeep-paliwal
Copy link
Contributor

@amulyakashyap09 Changes look good.
We will also need to add tests which validate API Mesh schema changes. Possibly a new test config in fixtures.

@amulyakashyap09
Copy link
Contributor Author

Done

Copy link
Contributor

@sandeep-paliwal sandeep-paliwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shazron shazron changed the title ACNA-1741 | Invalid Config Error fix: ACNA-1741 - invalid config error Aug 23, 2022
@amulyakashyap09 amulyakashyap09 merged commit 9bfd9f2 into master Aug 23, 2022
amulyakashyap09 added a commit that referenced this pull request Aug 23, 2022
@shazron shazron deleted the ACNA-1741-invalid-config-error branch August 25, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants