fix: ACNA-1634 - Replace Developer Terms of Service text with help text and Developer Console url #566
Conversation
amulyakashyap09
requested review from
shazron,
sandeep-paliwal,
arjuncooliitr and
MichaelGoberling
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 2607 2608 +1
Branches 473 473
=========================================
+ Hits 2607 2608 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shazron
changed the title
| @@ -18,6 +18,7 @@ const chalk = require('chalk') | |||
| // const aioLogger = require('@adobe/aio-lib-core-logging')('@adobe/aio-cli-plugin-app:init', { provider: 'debug' }) | |||
| const { Flags } = require('@oclif/core') | |||
| const generators = require('@adobe/generator-aio-app') | |||
| const hyperlinker = require('hyperlinker') | |||
There was a problem hiding this comment.
since we are already including @oclif/core, why not use CliUx.ux.url? So we don't need another dependency.
https://github.com/oclif/core/tree/main/src/cli-ux
There was a problem hiding this comment.
Hi @shazron ,
- oclif hyperlink functionality
CliUx.ux.urlseems to be broken, It returns promise back - Unable to use it with template-literals .. It is not working despite many efforts
- And
oclifhas underlying same packagehyperlinkforCliUx.ux.urlfunctionalilty.
Thanks,
There was a problem hiding this comment.
Looks like CliUx.ux.url does not return the "hyperlinked" text, but modifies the text stream directly. Let's not waste any more time on this and use hyperlink, your original plan
| @@ -18,6 +18,7 @@ const chalk = require('chalk') | |||
| // const aioLogger = require('@adobe/aio-lib-core-logging')('@adobe/aio-cli-plugin-app:init', { provider: 'debug' }) | |||
| const { Flags } = require('@oclif/core') | |||
| const generators = require('@adobe/generator-aio-app') | |||
| const hyperlinker = require('hyperlinker') | |||
There was a problem hiding this comment.
Looks like CliUx.ux.url does not return the "hyperlinked" text, but modifies the text stream directly. Let's not waste any more time on this and use hyperlink, your original plan
…A-1634-hyperlink-support
Description
Developer Terms of Service - revert the feature partially, in that when detecting that new Dev Terms are available and not accepted, we output some help text with something to this effect, and error exit:
You have not accepted the Developer Terms for your org XYZ. Please visit https://developer.adobe.com/console/home, select your XYZ org, and accept the terms.
I tried to have a direct url to an org, there doesn't seem to be one, just the home screen.
We delegate the acceptance to the Developer Console.
Related Issue
ACNA-1634
Motivation and Context
The link must always be shown for legal reasons.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: