Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1652 - update the delete command (move code from generator-aio-app) #570

Merged
merged 5 commits into from
Sep 14, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Aug 29, 2022

Description

This is the only code in aio app:delete that requires use of a generator. Removing the minimal code from the generator in another module into the command itself.

How Has This Been Tested?

  • manual test
  • npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #570 (7afacb0) into master (d56946a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #570   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2610      2619    +9     
  Branches       474       476    +2     
=========================================
+ Hits          2610      2619    +9     
Impacted Files Coverage Δ
src/commands/app/delete/ci.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MichaelGoberling MichaelGoberling self-requested a review September 13, 2022 17:01
@shazron shazron merged commit 3074f2d into master Sep 14, 2022
@shazron shazron deleted the story/ACNA-1652 branch September 14, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants