Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACNA-1787 | Bugfix : app init error - integration_type oauthsinglepageapp #577

Merged
merged 2 commits into from
Sep 24, 2022

Conversation

amulyakashyap09
Copy link
Contributor

@amulyakashyap09 amulyakashyap09 commented Sep 22, 2022

Description

  • Added required fields differently for integration_type: oauthsinglepageapp under oauth2

Related Issue

Closes #576
ACNA-1787

Motivation and Context

This is issue is breaking functionality while initialising a new App Builder project on production.

How Has This Been Tested?

  • New unit test cases added and all passing ✅
  • linking and running locally to aio-cli and then initialising the new project, ✅

Screenshots (if appropriate):

Screenshot 2022-09-22 at 5 54 22 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #577 (647e2d6) into master (bd6cbbd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #577   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2619      2619           
  Branches       476       476           
=========================================
  Hits          2619      2619           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sandeep-paliwal sandeep-paliwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shazron shazron merged commit 2225901 into master Sep 24, 2022
@shazron shazron deleted the bugfix/ACNA-1787 branch September 24, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app init error - integration_type oauthsinglepageapp
3 participants