Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1812 - aio app init --no-login --extension dx/excshell/1 should not error #584

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Sep 30, 2022

This is based on the master branch code, tested via the @adobe/aio-cli-next CLI.

The fix is passing a flag to the templates plugin to not process the template install.yml config, which requires a user login.

Closes #582

How Has This Been Tested?

  • npm test
  • manual test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #584 (db03e1a) into master (35dd448) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #584    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           50        53     +3     
  Lines         2629      2804   +175     
  Branches       478       528    +50     
==========================================
+ Hits          2629      2804   +175     
Impacted Files Coverage Δ
src/lib/defaults.js 100.00% <ø> (ø)
src/AddCommand.js 100.00% <100.00%> (ø)
src/TemplatesCommand.js 100.00% <100.00%> (ø)
src/commands/app/add/action.js 100.00% <100.00%> (ø)
src/commands/app/add/extension.js 100.00% <100.00%> (ø)
src/commands/app/add/web-assets.js 100.00% <100.00%> (ø)
src/commands/app/delete/extension.js 100.00% <100.00%> (ø)
src/commands/app/init.js 100.00% <100.00%> (ø)
src/BaseCommand.js 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sandeep-paliwal sandeep-paliwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purplecabbage purplecabbage merged commit fc3b1c0 into master Sep 30, 2022
@purplecabbage purplecabbage deleted the story/ACNA-1812 branch September 30, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio-next: app init --no-login --extension dx/excshell/1 should not error
4 participants