Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1807 - remove deprecated flags in the commands #586

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Sep 30, 2022

There have been deprecated flags in the app plugin. e.g. --skip-??? that already have other flag equivalents.
Removal of these flags is a breaking change, thus a major version bump to v10.

For the app deploy command I didn't change skip-deploy to deploy with allowNo:true because it didn't make sense at all, and removed any tests for skip-deploy.

How Has This Been Tested?

manual testing of app:

  • deploy
  • undeploy
  • build
  • run

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #586 (112248b) into master (488b207) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #586   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         2804      2796    -8     
  Branches       528       520    -8     
=========================================
- Hits          2804      2796    -8     
Impacted Files Coverage Δ
src/commands/app/undeploy.js 100.00% <ø> (ø)
src/commands/app/build.js 100.00% <100.00%> (ø)
src/commands/app/deploy.js 100.00% <100.00%> (ø)
src/commands/app/run.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sandeep-paliwal
Copy link
Contributor

@shazron we use one of the skip flags in our Github action( see https://github.com/adobe/aio-apps-action/blob/master/index.js#L29 ). We should update that code as well to use alternatives and have those actions published and referred to in CI/CD templates. Maybe needs to be tracked as separate issue.

@shazron
Copy link
Member Author

shazron commented Sep 30, 2022

@shazron we use one of the skip flags in our Github action( see https://github.com/adobe/aio-apps-action/blob/master/index.js#L29 ). We should update that code as well to use alternatives and have those actions published and referred to in CI/CD templates. Maybe needs to be tracked as separate issue.

Thanks Sandeep, changing it is easy enough in the action and generator-aio-app add-ci generator. I can add those PRs.
However I saw https://github.com/marketplace/actions/aio-apps is v1 while https://github.com/adobe/aio-apps-action is v2.0.1 - is there a reason v2 is not published to the marketplace

Copy link
Member

@purplecabbage purplecabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
removing these is not a breaking change, deprecating them was ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants