-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ACNA-1807 - remove deprecated flags in the commands #586
Conversation
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 53 53
Lines 2804 2796 -8
Branches 528 520 -8
=========================================
- Hits 2804 2796 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@shazron we use one of the skip flags in our Github action( see https://github.com/adobe/aio-apps-action/blob/master/index.js#L29 ). We should update that code as well to use alternatives and have those actions published and referred to in CI/CD templates. Maybe needs to be tracked as separate issue. |
Thanks Sandeep, changing it is easy enough in the action and generator-aio-app add-ci generator. I can add those PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
removing these is not a breaking change, deprecating them was ...
@sandeep-paliwal I filed: |
There have been deprecated flags in the app plugin. e.g.
--skip-???
that already have other flag equivalents.Removal of these flags is a
breaking change
, thus amajor version bump
to v10.For the
app deploy
command I didn't changeskip-deploy
todeploy
withallowNo:true
because it didn't make sense at all, and removed any tests forskip-deploy
.How Has This Been Tested?
manual testing of app:
Screenshots (if appropriate):
Types of changes
Checklist: