Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1810 - update Template Registry API usage for OR category clauses #589

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 3, 2022

How Has This Been Tested?

  • npm test
  • manual test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #589 (abbff60) into master (9f8b4a1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #589   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         2800      2800           
  Branches       522       522           
=========================================
  Hits          2800      2800           
Impacted Files Coverage Δ
src/commands/app/add/action.js 100.00% <100.00%> (ø)
src/commands/app/init.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MichaelGoberling MichaelGoberling self-requested a review October 3, 2022 14:45
@purplecabbage
Copy link
Member

Lgtm!

@shazron shazron merged commit 8b69a11 into master Oct 4, 2022
@shazron shazron deleted the story/ACNA-1810 branch October 4, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants