Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable templates that use services unavailable to the user's org #593

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

MichaelGoberling
Copy link
Contributor

Description

During app init and app add action, disable template options that use services that are not supported by the user's organization. This matches the user experience provided by aio templates discover --interactive.

Related Issue

closes #590
dependent on adobe/inquirer-table-checkbox#2

Motivation and Context

This workflow results in an un-deployable project.

How Has This Been Tested?

  • Tested locally with a linked version of the app plugin.
  • Ran npm run test locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #593 (ce8700d) into master (8b69a11) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #593   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         2800      2805    +5     
  Branches       522       524    +2     
=========================================
+ Hits          2800      2805    +5     
Impacted Files Coverage Δ
src/commands/app/add/web-assets.js 100.00% <ø> (ø)
src/TemplatesCommand.js 100.00% <100.00%> (ø)
src/commands/app/add/action.js 100.00% <100.00%> (ø)
src/commands/app/init.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron merged commit 5992f92 into master Oct 4, 2022
@shazron shazron deleted the issue-590/disable-templates-unavailable-to-org branch October 4, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio-next: app init / app add should not allow selecting templates unavailable to the org
2 participants