Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1822 - aio app add action fails with console error without local .aio file #595

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 4, 2022

Closes #592

How Has This Been Tested?

  • npm test
  • manual test (aio app add action, aio app add service, aio app delete service)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron marked this pull request as draft October 4, 2022 13:59
@MichaelGoberling
Copy link
Contributor

Tests need some updating, but otherwise LGTM!

@shazron
Copy link
Member Author

shazron commented Oct 4, 2022

I was too fast on the trigger. Tests updated.

@shazron shazron marked this pull request as ready for review October 4, 2022 14:13
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #595 (e2ddf4a) into master (5992f92) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #595   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         2805      2808    +3     
  Branches       524       525    +1     
=========================================
+ Hits          2805      2808    +3     
Impacted Files Coverage Δ
src/commands/app/add/action.js 100.00% <100.00%> (ø)
src/commands/app/add/service.js 100.00% <100.00%> (ø)
src/commands/app/delete/service.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron merged commit b91d217 into master Oct 4, 2022
@shazron shazron deleted the aio-missing branch October 4, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio-next: aio-next app add action fails with console error without local .aio file
2 participants