Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deploy error (Production workspace): Error: Cannot read properties of undefined (reading 'getProject') #599

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 10, 2022

Closes #598

How Has This Been Tested?

  • npm test
  • manual test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #599 (ef9adc6) into master (29a6089) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #599   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         2808      2809    +1     
  Branches       525       526    +1     
=========================================
+ Hits          2808      2809    +1     
Impacted Files Coverage Δ
src/commands/app/deploy.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@amulyakashyap09 amulyakashyap09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@shazron shazron merged commit 3986d36 into master Oct 10, 2022
@shazron shazron deleted the story/ACNA-1830 branch October 10, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy error: Error: Cannot read properties of undefined (reading 'getProject')
2 participants