Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1839 - not properly showing templates only supported by my org #601

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 11, 2022

Fixes #600

How Has This Been Tested?

  • npm test
  • manual test via aio plugins link .

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron changed the title fix: ACNA-1839 - not showing templates supported by my org fix: ACNA-1839 - not showing templates only supported by my org Oct 11, 2022
@shazron shazron changed the title fix: ACNA-1839 - not showing templates only supported by my org fix: ACNA-1839 - not properly showing templates only supported by my org Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #601 (4d1bc57) into master (8447303) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4d1bc57 differs from pull request most recent head 20117f3. Consider uploading reports for the commit 20117f3 to get more accurate results

@@            Coverage Diff            @@
##            master      #601   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         2809      2812    +3     
  Branches       526       527    +1     
=========================================
+ Hits          2809      2812    +3     
Impacted Files Coverage Δ
src/TemplatesCommand.js 100.00% <100.00%> (ø)
src/commands/app/init.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MichaelGoberling MichaelGoberling self-requested a review October 11, 2022 03:51
@shazron shazron merged commit 80afd77 into master Oct 11, 2022
@shazron shazron deleted the story/ACNA-1839 branch October 11, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not properly showing templates only supported by my org
3 participants