Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-1786 - serve-static hook error #617

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Nov 14, 2022

Closes #609

How Has This Been Tested?

  1. npm test
  2. manual test (link local app plugin, set serve-static hook, then aio app run)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron self-assigned this Nov 14, 2022
@shazron shazron mentioned this pull request Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #617 (da1d09c) into master (70b9a42) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #617   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         2812      2815    +3     
  Branches       527       528    +1     
=========================================
+ Hits          2812      2815    +3     
Impacted Files Coverage Δ
src/commands/app/deploy.js 100.00% <100.00%> (ø)
src/lib/run-dev.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MichaelGoberling
Copy link
Contributor

MichaelGoberling commented Nov 17, 2022

Not sure what's going on with codecov. Investigating...

Edit: Re-ran checks, we're good to go. 🤷

@MichaelGoberling MichaelGoberling merged commit 59411b6 into master Nov 17, 2022
@MichaelGoberling MichaelGoberling deleted the story/ACNA-1786 branch November 17, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serve static hook error
2 participants