Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow --no-publish with --action #618

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

MichaelGoberling
Copy link
Contributor

Description

Using the --action flag sets --publish to false, therefore we should allow --no-publish when using --action.

Related Issue

Closes #607

Motivation and Context

Confusing flags

How Has This Been Tested?

Locally linked app plugin and npm run test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #618 (49e47c2) into master (70b9a42) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #618   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         2812      2813    +1     
  Branches       527       527           
=========================================
+ Hits          2812      2813    +1     
Impacted Files Coverage Δ
src/commands/app/deploy.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MichaelGoberling MichaelGoberling self-assigned this Nov 16, 2022
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice didn't know this was possible in oclif.
lgtm

@MichaelGoberling MichaelGoberling merged commit 0ea9df6 into master Nov 17, 2022
@MichaelGoberling MichaelGoberling deleted the allow-no-publish-action branch November 17, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy only a specific action fails with --no-publish
2 participants