Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send telemetry event for the template that was selected #639

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Mar 16, 2023

Description

This sends an event to telemetry via the hook to track that a template was selected.

Related Issue

ACNA-2123

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #639 (7d8686a) into master (08928fc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #639   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           54        54           
  Lines         2828      2834    +6     
  Branches       531       533    +2     
=========================================
+ Hits          2828      2834    +6     
Impacted Files Coverage Δ
src/TemplatesCommand.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This will be good to track

Q: Can we fire this hook during initNoLogin too or do we need to be logged in to report telemetry?

@shazron
Copy link
Member

shazron commented Mar 16, 2023

Nice catch @MichaelGoberling, I don't believe telemetry needs login -- @purplecabbage I think as well that this should also fire in initNoLogin

@purplecabbage purplecabbage merged commit 69a7c57 into master Mar 17, 2023
@purplecabbage purplecabbage deleted the TrackTemplates branch March 17, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants