Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aio app pack, aio app install output cleanup, fixes #671

Merged
merged 4 commits into from
May 12, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented May 11, 2023

  • add npm install step to aio app install (if not aio app test will fail)
  • aio app pack will not include the output zip (if it exists in the project)
  • cleaned up info output by using ora spinner
  • updated tests and coverage

How Has This Been Tested?

  • npm test
  • manual tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #671 (e44de8c) into master (d520556) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #671   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3022      3065   +43     
  Branches       561       569    +8     
=========================================
+ Hits          3022      3065   +43     
Impacted Files Coverage Δ
src/commands/app/install.js 100.00% <100.00%> (ø)
src/commands/app/pack.js 100.00% <100.00%> (ø)
src/commands/app/test.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron merged commit def82b7 into master May 12, 2023
@shazron shazron deleted the app-install-fixes branch May 12, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants