Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pre-release warning text, hide pre-release commands from help listing #674

Merged
merged 1 commit into from
May 16, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented May 16, 2023

  1. fixed app install unzip concurrency issue

How Has This Been Tested?

  • npm test
  • manual tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…p listing

1. fixed app install unzip concurrency issue
@shazron shazron requested a review from sandeep-paliwal May 16, 2023 04:24
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #674 (f667ffc) into master (def82b7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #674   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3065      3072    +7     
  Branches       569       569           
=========================================
+ Hits          3065      3072    +7     
Impacted Files Coverage Δ
src/BaseCommand.js 100.00% <100.00%> (ø)
src/commands/app/install.js 100.00% <100.00%> (ø)
src/commands/app/pack.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron self-assigned this May 16, 2023
@shazron shazron merged commit 0eaa3fb into master May 16, 2023
@shazron shazron deleted the add-prerelease-text branch May 16, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants