Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message to users around template selection #684

Merged
merged 4 commits into from
Jun 14, 2023
Merged

Conversation

pru55e11
Copy link
Contributor

Making it more clear that users can skip template selection during aio app init

#683

Motivation and Context

Users are asking for help at this step in slack

How Has This Been Tested?

tested plugin locally with and without template selection

Screenshots (if appropriate):

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@pru55e11 pru55e11 marked this pull request as draft June 14, 2023 20:38
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #684 (1a0aece) into master (5806ad5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #684   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3072      3072           
  Branches       569       569           
=========================================
  Hits          3072      3072           
Impacted Files Coverage Δ
src/TemplatesCommand.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pru55e11 pru55e11 linked an issue Jun 14, 2023 that may be closed by this pull request
@pru55e11 pru55e11 marked this pull request as ready for review June 14, 2023 20:50
@pru55e11 pru55e11 merged commit d18aa8b into master Jun 14, 2023
@pru55e11 pru55e11 deleted the ACNA-2298 branch June 14, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve template selection wording
2 participants