Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-3024 - deploy single action error #808

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Jul 15, 2024

fixes #805

Description

Cleaned up the initialization of libConsoleCLI in the Deploy command. It is unnecessary to initialize it in the command's run method, since in BaseCommand, the getter function is already in a singleton pattern and the instance is lazy loaded.

Any functions that need this instance can just call it directly, and it does not have to be passed down from the run() command, where the initialization is dependent on potentially faulty logic (that has been removed).

How Has This Been Tested?

  • npm test
  • manual testing
  • aio app init MyApp (create an exc-shell extension app)
  • aio app use (choose Production workspace)
  • aio app deploy -a your_action_to_deploy

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (12e579a) to head (9098f3b).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #808   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3242      3242           
  Branches       617       616    -1     
=========================================
  Hits          3242      3242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sandeep-paliwal sandeep-paliwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shazron shazron merged commit 9f9c7bd into master Jul 15, 2024
8 checks passed
@shazron shazron deleted the story/ACNA-3024 branch July 15, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy single action problem
3 participants