Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update on-push-publish-to-npm.yml #810

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Aug 19, 2024

Add the parameter to the github action, so that on publish, the scope is always public.
If not, we would have to update it in npm manually from private to public, and that requires someone with npm org admin privileges.

This is not a problem if it's already public - but generally when you first publish it (especially for a new repo).
Why this PR? Since we often copy workflows from existing repos, I am adding it here to the 2 most popular repos so this issue won't happen.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (32fdd10) to head (6235ca1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #810   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3323      3323           
  Branches       641       641           
=========================================
  Hits          3323      3323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purplecabbage purplecabbage self-requested a review October 9, 2024 07:09
@purplecabbage
Copy link
Member

I approve although not sure how to do it officially on mobile.

@shazron shazron merged commit 9b36d06 into master Oct 9, 2024
8 checks passed
@shazron shazron deleted the update-action-params branch October 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants