Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock dev #816

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Unblock dev #816

merged 3 commits into from
Nov 9, 2024

Conversation

purplecabbage
Copy link
Member

Description

This will clean up master, currently running without env=stage will call a non-existent service.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but are the test failures expected?

@shazron
Copy link
Member

shazron commented Nov 4, 2024

Looks like the lines are not covered by the tests:

 src/lib                                    |   99.79 |    99.75 |     100 |   99.79 |                   
  audit-logger.js                           |   96.66 |     97.5 |     100 |   96.36 | 70-71 

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b36d06) to head (769fa44).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #816   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3323      3330    +7     
  Branches       641       643    +2     
=========================================
+ Hits          3323      3330    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purplecabbage purplecabbage merged commit 31ebbbd into master Nov 9, 2024
8 checks passed
@purplecabbage purplecabbage deleted the UnblockDev branch November 9, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants