Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call console if we are not publishing, was forcing login #818

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

purplecabbage
Copy link
Member

Description

Related Issue

This closes #817

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (31ebbbd) to head (dfcdbc6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #818   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         3330      3330           
  Branches       643       643           
=========================================
  Hits          3330      3330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purplecabbage
Copy link
Member Author

[ACNA-3255]

@purplecabbage purplecabbage merged commit b1b95f6 into master Nov 9, 2024
8 checks passed
@purplecabbage purplecabbage deleted the issue#685 branch November 9, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aio app deploy --no-publish requires login
3 participants