Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting action concurrency in manifest #176

Closed
alexkli opened this issue Jun 24, 2020 · 4 comments · Fixed by #177
Closed

Support setting action concurrency in manifest #176

alexkli opened this issue Jun 24, 2020 · 4 comments · Fixed by #177
Assignees
Labels
enhancement New feature or request

Comments

@alexkli
Copy link
Contributor

alexkli commented Jun 24, 2020

Describe the solution you'd like

Be able to set concurrency limit of an action in the manifest.yml.

Probably add here: https://github.com/adobe/aio-cli-plugin-runtime/blob/master/src/runtime-helpers.js#L463-L468

Describe alternatives you've considered
No alternatives, other than manually setting it using wsk after deployment through aio, which is a fragile and complicated process.

Additional context
Being able to set a different concurrency than the default 200 in Adobe IO Runtime is important for many use cases.

Looks like it's not possible in wskdeploy yet, only wsk: apache/openwhisk-wskdeploy#1062

The manifest spec does not include it either. Note that concurrentActivations is a different limit.

@alexkli
Copy link
Contributor Author

alexkli commented Jun 24, 2020

I might be able to provide a PR later this week.

@meryllblanchet meryllblanchet added the enhancement New feature or request label Jun 25, 2020
@meryllblanchet
Copy link

meryllblanchet commented Jun 25, 2020

Thanks for the proposal @alexkli ! Looking forward to the PR then :)

Note, as we are refactoring both Runtime and App plugins to simplify the underlying dependencies, the PR might be a better fit for https://github.com/adobe/aio-lib-runtime.

Could you sync-up with @purplecabbage and @Himavanth before?

@aiojbot
Copy link
Collaborator

aiojbot commented Jun 25, 2020

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-829

alexkli added a commit to alexkli/aio-cli-plugin-runtime that referenced this issue Jun 25, 2020
@alexkli
Copy link
Contributor Author

alexkli commented Jun 25, 2020

@meryllblanchet @purplecabbage @Himavanth PR ready here: #177

I leave the refactoring to you. The current aio still uses the runtime-helpers.js from https://github.com/adobe/aio-cli-plugin-runtime, so that was the only way to build and test this change.

purplecabbage pushed a commit that referenced this issue Jun 25, 2020
* Support setting action concurrency in manifest #176
purplecabbage pushed a commit to purplecabbage/aio-cli-plugin-runtime that referenced this issue Jul 16, 2020
* Support setting action concurrency in manifest adobe#176
bhageena pushed a commit to bhageena/aio-cli-plugin-runtime that referenced this issue Jul 21, 2021
* Support setting action concurrency in manifest adobe#176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants