Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-2081 - remove installing latest npm #392

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Mar 6, 2023

Fixes #388

How Has This Been Tested?

The checks will run the test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #392 (d14b4ea) into master (5bacaaf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #392   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          238       238           
  Branches        47        47           
=========================================
  Hits           238       238           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron marked this pull request as ready for review March 6, 2023 12:00
@shazron shazron changed the title fix: remove installing latest npm fix: ACNA-2081 - remove installing latest npm Mar 6, 2023
@shazron shazron merged commit 61b2143 into master Mar 8, 2023
@shazron shazron deleted the remove-npm-latest branch March 8, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updating npm in Github Actions, under Windows runs into permission error
3 participants