Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ACNA-2219 - add OAuth Server-to-Server api calls and e2e tests #63

Merged
merged 16 commits into from
Jun 6, 2023
Merged

fix: ACNA-2219 - add OAuth Server-to-Server api calls and e2e tests #63

merged 16 commits into from
Jun 6, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented May 25, 2023 •
edited
Loading

How Has This Been Tested?

  • npm run e2e (all tests pass)
  • npm test (all tests pass with 100% code coverage)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

shazron and others added 15 commits May 24, 2023 18:23
@shazron
update with new transporter api OpenAPI spec
946647e
@shazron
add createOAuthServerToServerCredential
8be0d5a
@shazron
add subscribeOAuthServerToServerIntegrationToServices
e0b8d88
@shazron
fix lint issue and api paths
f45bdd7
@shazron
add oauth-server-to-server e2e code, uncommented code (added test ski…
8d4cbe0 
…p instead)
@shazron
updates for oauth s2s
b668f88
@shazron
fix schema validator lint issues
393c2f1
@shazron
two apis have been moved under a new tag "workspaces" (from "Extensio…
bdaf284 
…ns"), and two apis have been removed from the OpenAPI spec:

1. getAllExtensionPoints
2. getApplicationExtensions
@shazron
updated swagger: Get all available extension points was re-added (swa…
20a2607 
…gger generation issue)
@shazron
add patch-spec script
8c9a13b
@shazron
re-add api calls under Extensions tag
884efed
@shazron
all oauth server-to-server credential e2e tests pass
f8065b0
@shazron
all e2e tests now pass
c30f76e
@shazron
remove commented out code
212717d
@shazron
completed code coverage 100%
a8c7747
@shazron shazron marked this pull request as ready for review May 26, 2023 19:03
@codecov
Copy link

codecov bot commented May 26, 2023 •
edited
Loading

Codecov Report

Merging #63 (5d2dc59) into master (54a9743) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          485       505   +20     
  Branches        15        15           
=========================================
+ Hits           485       505   +20
Impacted Files Coverage Δ
src/SDKErrors.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

amulyakashyap09
amulyakashyap09 approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@amulyakashyap09 amulyakashyap09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bin/.eslintrc.json Show resolved Hide resolved
@shazron shazron mentioned this pull request May 29, 2023
Merged
10 tasks
moritzraho
moritzraho approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
just curious why the patch was needed

@shazron shazron mentioned this pull request Jun 1, 2023
Merged
10 tasks
@purplecabbage purplecabbage merged commit 560d654 into master Jun 6, 2023
@purplecabbage purplecabbage deleted the story/ACNA-2219 branch June 7, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelGoberling MichaelGoberling MichaelGoberling approved these changes

@amulyakashyap09 amulyakashyap09 amulyakashyap09 approved these changes

@moritzraho moritzraho moritzraho approved these changes

@sandeep-paliwal sandeep-paliwal Awaiting requested review from sandeep-paliwal

@purplecabbage purplecabbage Awaiting requested review from purplecabbage

@arjuncooliitr arjuncooliitr Awaiting requested review from arjuncooliitr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shazron @moritzraho @amulyakashyap09 @MichaelGoberling @purplecabbage