Skip to content

Conversation

shazron
Copy link
Member

@shazron shazron commented Jan 20, 2020

Description

Trying to improve autocomplete in VS Code

Motivation and Context

Better developer experience.

How Has This Been Tested?

  1. npm test
  2. vs code autocomplete

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          36     36           
  Branches        2      2           
=====================================
  Hits           36     36
Impacted Files Coverage Δ
src/AioCoreSDKError.js 100% <ø> (ø) ⬆️
src/AioCoreSDKErrorWrapper.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ece8b3...9680bdd. Read the comment docs.

@shazron shazron merged commit 347c79f into master Jan 20, 2020
@shazron shazron deleted the typings branch January 20, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant