Skip to content

Conversation

@shazron
Copy link
Member

@shazron shazron commented Jan 7, 2025

closes #83

Tested by local installing this branch with node@v22:

mkdir test
cd test
npm init -y
npm i path/to/branch/code/here
node -e "require('@adobe/aio-lib-core-networking')"

The punycode warning should not be printed out.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (27abfcf) to head (a072e29).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          139       139           
  Branches        31        31           
=========================================
  Hits           139       139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node v22 - punycode module deprecated

4 participants