Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ACNA-1854 - add IMS OAuth Server to Server plugin #69

Merged
merged 4 commits into from
May 25, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented Apr 3, 2023

Changes 📦

  • add new OAuth Server to Server (OAuth STS) plugin to handle OAuth client credentials grant type

Pending 🚧

  • Need to update README in this repo

Pre-requisites 🔖

How Has This Been Tested? 🔧

  • npm test
  • manual tests pending

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron changed the title feat: ACNA-1854 - add ims OAuth Server to Server plugin feat: ACNA-1854 - add IMS OAuth Server to Server plugin Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #69 (c08610f) into master (68c9d50) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c08610f differs from pull request most recent head 9268cf9. Consider uploading reports for the commit 9268cf9 to get more accurate results

@@            Coverage Diff            @@
##            master       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines          226       251   +25     
  Branches        37        41    +4     
=========================================
+ Hits           226       251   +25     
Impacted Files Coverage Δ
src/ims-oauth_server_to_server.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron marked this pull request as ready for review April 5, 2023 12:40
@MichaelGoberling
Copy link
Contributor

Naive Q: What is the reason for there being both a sync and async function checking for supported keys? Is supports needed by another lib?

@purplecabbage
Copy link
Member

purplecabbage commented May 25, 2023

lgtm!
tiny tiny nit pick: the copyright year in the tests file is old. copy-pasta

@shazron
Copy link
Member Author

shazron commented May 25, 2023

Naive Q: What is the reason for there being both a sync and async function checking for supported keys? Is supports needed by another lib?

The async version is probably to easily chain it with the async call in the ims lib. I don't recall why there is a sync version its been so long

Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shazron
Copy link
Member Author

shazron commented May 25, 2023

tiny tiny nit pick: the copyright year in the tests file is old. copy-pasta

fixed

@shazron
Copy link
Member Author

shazron commented May 25, 2023

@shazron shazron merged commit a13f908 into master May 25, 2023
@shazron shazron deleted the story/ACNA-1854 branch May 25, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants