-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ACNA-1854 - add IMS OAuth Server to Server plugin #69
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 226 251 +25
Branches 37 41 +4
=========================================
+ Hits 226 251 +25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Naive Q: What is the reason for there being both a sync and async function checking for supported keys? Is |
lgtm! |
The async version is probably to easily chain it with the async call in the ims lib. I don't recall why there is a sync version its been so long |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixed |
codecov is 502'ing, but coverage is 100% : https://app.codecov.io/gh/adobe/aio-lib-ims-oauth/commit/9268cf9173086576018b6613a454eea916da4f8c |
Changes 📦
Pending 🚧
Pre-requisites 🔖
How Has This Been Tested? 🔧
Types of changes
Checklist: