Memory limits follow documentation

[fe-lix-]

Description

Adobe Documentation state that memory limits should be configured as follow in the app.config.yaml

application:
  actions: actions
  web: web-src
  runtimeManifest:
    packages:
      mypackage:
        actions:
          myactions:
            function: actions/myaction.js
            runtime: 'nodejs:14'
            limits:
              memory: 512

Currently the code only looks for property memorySize and not memory

Documentation 1

Documentation 2

Related Issue

#105

Motivation and Context

The behaviour difference has been found by a customer here : https://experienceleaguecommunities.adobe.com/t5/project-firefly-questions/can-t-change-action-memory-limit/td-p/454197

How Has This Been Tested?

• Automated tests

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #106 (12adc7a) into master (975fd68) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1290      1290           
  Branches       338       338           
=========================================
  Hits          1290      1290           

Impacted Files	Coverage Δ
src/utils.js	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[arjuncooliitr]

LGTM

[purplecabbage]

It looks like the docs were wrong, OpenWhisk defines memorySize as the value ...
https://github.com/apache/openwhisk-wskdeploy/blob/03df1126c3b5205d642738479a08bb7cd66a03b3/tests/dat/manifest_data_compose_actions_for_limits.yaml#L29

Should we change this to support both?

[arjuncooliitr]

Maybe, we can support both memory and memorySize inputs, just thinking wouldn't it be better to go with one variable value memorySize to avoid confusion

[fe-lix-]

I think wskdeploy and the OpenWhisk API do not agree that probably what stems the confusion.

wskdeploy use memorySize but the OpenWhisk API uses memory.

https://github.com/apache/openwhisk/blob/59b67fe96f44e573f3348afed966a1cdaf80ddf2/docs/reference.md?plain=1#L80

[purplecabbage]

Merging, thanks @fe-lix-
I missed that you are in fact supporting both!