Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ACNA-1962 - support node environment variable NODE_TLS_REJECT_UNAUTHORIZED=0 #115

Merged
merged 5 commits into from
Feb 6, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented Jan 30, 2023

Closes #111

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron requested review from moritzraho and purplecabbage and removed request for moritzraho January 30, 2023 10:20
@shazron shazron changed the title fix: support node environment variable NODE_TLS_REJECT_UNAUTHORIZED=0 feat: support node environment variable NODE_TLS_REJECT_UNAUTHORIZED=0 Jan 30, 2023
@shazron shazron requested a review from moritzraho January 30, 2023 10:21
@shazron shazron self-assigned this Jan 30, 2023
@shazron shazron changed the title feat: support node environment variable NODE_TLS_REJECT_UNAUTHORIZED=0 feat: ACNA-1962 - support node environment variable NODE_TLS_REJECT_UNAUTHORIZED=0 Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #115 (04f94d2) into master (64cedaf) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #115   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1291      1293    +2     
  Branches       339       340    +1     
=========================================
+ Hits          1291      1293    +2     
Impacted Files Coverage Δ
src/RuntimeAPI.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. TY for type updates 👍

@shazron shazron merged commit e56addd into master Feb 6, 2023
@shazron shazron deleted the story/ACNA-1962 branch February 6, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support node environment variable NODE_TLS_REJECT_UNAUTHORIZED=0
5 participants