Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nodejs:20 kind #165

Merged
merged 6 commits into from
Nov 1, 2023
Merged

feat: support nodejs:20 kind #165

merged 6 commits into from
Nov 1, 2023

Conversation

shazron
Copy link
Member

@shazron shazron commented Sep 20, 2023

Note that due to #138 we do a server check, and since the server as of now supports nodejs:20, nodejs:10, and nodejs:12, it will not error out but will debug log a mismatch (instead of throwing an exception - this is so the client code is not the gatekeeper).

note: node-10 and node-12 will still be supported and will be removed at a later date according to our deprecation roadmap.

How Has This Been Tested?

  • npm test
  • manual tests pending

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #165 (e845ab6) into master (2a26404) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1300      1300           
  Branches       345       345           
=========================================
  Hits          1300      1300           
Files Coverage Δ
src/utils.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@purplecabbage
Copy link
Member

Does it make sense to remove 10|12 now, and wait for the backend to remove 20?

@shazron shazron marked this pull request as ready for review October 31, 2023 12:54
@shazron shazron changed the title feat: support nodejs:20 kind, and remove nodejs:10, and nodejs:12 support feat: support nodejs:20 kind Nov 1, 2023
@shazron shazron merged commit aed770b into master Nov 1, 2023
7 checks passed
@shazron shazron deleted the node-20-support branch November 1, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants